Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider implications of showing the old room when leaving the upgraded room #8539

Closed
turt2live opened this issue Feb 12, 2019 · 6 comments
Closed

Consider implications of showing the old room when leaving the upgraded room #8539

turt2live opened this issue Feb 12, 2019 · 6 comments
Assignees
@turt2live
Labels
A-Room-Upgrades P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Milestone
Room upgrade bug ...

Comments

@turt2live
Copy link
Member

Opening this as a UI issue to propagate to the other projects as needed.

There's some concern that leaving an upgraded room magically makes the old room appear in the room list, which could confuse people. Instead, maybe we should be leaving the chain of rooms?
@lampholder lampholder added ui/ux P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-Upgrades labels Feb 19, 2019
@lampholder
Copy link
Member

Ugh, yes, I hadn't considered that.

@turt2live turt2live mentioned this issue Feb 24, 2019
Closed
@anoadragon453
Copy link
Member

anoadragon453 commented Mar 1, 2019 •
edited
Loading

Just got confused by this today.

@lampholder
Copy link
Member

I don't think we expect regular users to understand the mechanisms underpinning room upgrades. Therefore, it is highly unlikely that when a regular user chooses to leave a room that happens to be upgraded, they're intending to leave the newer version and remain a member of the old version.

My opinion is that we should honour users' intention and leave all versions of the room at once.

@turt2live turt2live self-assigned this Mar 22, 2019
turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 22, 2019
@turt2live
Add functions for getting room upgrade history and leaving those rooms
1cda95f 
Required for element-hq/element-web#8539
@turt2live turt2live mentioned this issue Mar 22, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 22, 2019
@turt2live
Use leaveRoomChain when leaving a room
a34a8bb 
Requires matrix-org/matrix-js-sdk#868
Fixes element-hq/element-web#8539

We don't need to use leaveRoomChain when rejecting invites because we won't have the references needed. This leaves the couple spots where we do actually leave a room, and use the new function for that.
@turt2live turt2live mentioned this issue Mar 22, 2019
Merged
@lampholder
Copy link
Member

This didn't seem to work when I tested just now on the test server/riot instance you provisioned for me @turt2live :\

@lampholder lampholder reopened this May 1, 2019
@lampholder
Copy link
Member

Inasmuch as, I /parted the new room, and the old room popped back into the room list

@lampholder
Copy link
Member

Stand down: I'm an idiot.

@aaronraimist aaronraimist mentioned this issue Jul 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-Upgrades P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
Room upgrade bug hunt: 1.0 Edition
Development

No branches or pull requests
3 participants
@turt2live @anoadragon453 @lampholder