Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SenderProfile doesn't give colour to usernames for file uploads, etc #9482

Closed
anoadragon453 opened this issue Apr 15, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5719
Closed

SenderProfile doesn't give colour to usernames for file uploads, etc #9482

anoadragon453 opened this issue Apr 15, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5719
Assignees
@turt2live
Labels
P2 T-Defect

Comments

@anoadragon453
Copy link
Member

image

The "someuser uploaded a file" text is in white, which makes it tricky to distinguish it from a normal message. Perhaps the text (or part of it) should be in the user's color instead?

Version information

  • Platform: web
  • Browser: Chrome
  • OS: Debian Linux
  • URL: riot.im/develop
@turt2live
Copy link
Member

This is probably because we don't give the username any of the colouring

@turt2live turt2live changed the title "xxx uploaded a file" text is hard to distinguish from message text SenderProfile doesn't give colour to usernames for file uploads, etc Apr 15, 2019
@t3chguy t3chguy mentioned this issue Jul 16, 2020
Closed
@turt2live turt2live mentioned this issue Aug 26, 2020
Closed
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 5, 2021
@turt2live
UI refresh for uploaded files
5d6e3d5 
Fixes element-hq/element-web#16557
Fixes element-hq/element-web#9482 (technically)

There's two changes in this:
1. The actual file body in the timeline now has a placeholder thing.
2. We're intentionally dropping all the "Travis uploaded a file" sender profile states.
@turt2live turt2live mentioned this issue Mar 5, 2021
Merged
@turt2live turt2live self-assigned this Mar 5, 2021
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P2 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI refresh for uploaded files matrix-org/matrix-react-sdk
4 participants
@jryans @turt2live @anoadragon453 @lampholder