Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/sync error Error: CORS request rejected #9608

Closed
dajohi opened this issue May 1, 2019 · 1 comment
Closed

/sync error Error: CORS request rejected #9608

dajohi opened this issue May 1, 2019 · 1 comment

Comments

@dajohi
Copy link

dajohi commented May 1, 2019

When using https://riot.im/app logged into a third-party homeserver matrix.example.com (changed for sake of PR) with Firefox, hitting F5/refresh I see:

/sync error Error: CORS request rejected: https://matrix.example.com/_matrix/client/r0/sync?filter=2&timeout=30000&since=s1010070_41078931_376_3148196_408924_861_1044_174076_38 bundle.js:41:18094
    r https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:41
    _onSyncError https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:70
    e https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:70
    E https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:23
    _invoke https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:23
    t https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:23
    c https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _promiseRejected https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _settlePromise https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _rejectPromises https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _settlePromises https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    p https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    d https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _drainQueues https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    drainQueues https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    a https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:63
    A https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:63
    u https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:41

Error: "CORS request rejected: https://matrix.example.com/_matrix/client/r0/sync?filter=2&timeout=30000&since=s1010070_41078931_376_3148196_408924_861_1044_174076_38"
    c https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:23
    onreadystatechange https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:23
bundle.js:41:18094
    r https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:41
    _onSyncError https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:70
    e https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:70
    E https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:23
    _invoke https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:23
    t https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:23
    c https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _promiseRejected https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _settlePromise https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _rejectPromises https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _settlePromises https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    p https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    d https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    _drainQueues https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    drainQueues https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:1
    a https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:63
    A https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:63
    u https://riot.im/app/bundles/ffb4fa6e8a9bd1bedd9a/bundle.js:41

Does the third-party synapse server need to implement CORS?
@dajohi dajohi added the T-Defect label May 1, 2019
@jryans
Copy link
Collaborator

jryans commented May 1, 2019

Yes, servers are generally expected to set the CORS headers on responses.

If Synapse is not doing that for some request, please file an issue on that repo. If it's some other HS, they should likely change to set these headers.

This doesn't seem like Riot issue, so I'll close this, but please re-open if I misunderstood.

@jryans jryans closed this as completed May 1, 2019
@jryans jryans added invalid and removed T-Defect labels May 1, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Dec 6, 2022
@su-ex
Merge tag 'v1.11.16' into sc
58d68a5 
* Further improve replies ([\element-hq#6396](matrix-org/matrix-react-sdk#6396)). Fixes element-hq#19074, element-hq#18194 element-hq#18027 and element-hq#19179.
* Enable users to join group calls from multiple devices ([\element-hq#9625](matrix-org/matrix-react-sdk#9625)).
* fix(visual): make cursor a pointer for summaries ([\element-hq#9419](matrix-org/matrix-react-sdk#9419)). Contributed by @r00ster91.
* Add placeholder for rich text editor ([\element-hq#9613](matrix-org/matrix-react-sdk#9613)).
* Consolidate public room search experience ([\element-hq#9605](matrix-org/matrix-react-sdk#9605)). Fixes element-hq#22846.
* New password reset flow ([\element-hq#9581](matrix-org/matrix-react-sdk#9581)). Fixes element-hq#23131.
* Device manager - add tooltip to device details toggle ([\#9594](matrix-org/matrix-react-sdk#9594)).
* sliding sync: add lazy-loading member support ([\element-hq#9530](matrix-org/matrix-react-sdk#9530)).
* Limit formatting bar offset to top of composer ([\element-hq#9365](matrix-org/matrix-react-sdk#9365)). Fixes element-hq#12359. Contributed by @owi92.
* Fix issues around up arrow event edit shortcut ([\element-hq#9645](matrix-org/matrix-react-sdk#9645)). Fixes element-hq#18497 and element-hq#18964.
* Fix search not being cleared when clicking on a result ([\element-hq#9635](matrix-org/matrix-react-sdk#9635)). Fixes element-hq#23845.
* Fix screensharing in 1:1 calls ([\element-hq#9612](matrix-org/matrix-react-sdk#9612)). Fixes element-hq#23808.
* Fix the background color flashing when joining a call ([\element-hq#9640](matrix-org/matrix-react-sdk#9640)).
* Fix the size of the 'Private space' icon ([\element-hq#9638](matrix-org/matrix-react-sdk#9638)).
* Fix reply editing in rich text editor (https ([\element-hq#9615](matrix-org/matrix-react-sdk#9615)).
* Fix thread list jumping back down while scrolling ([\element-hq#9606](matrix-org/matrix-react-sdk#9606)). Fixes element-hq#23727.
* Fix regression with TimelinePanel props updates not taking effect ([\element-hq#9608](matrix-org/matrix-react-sdk#9608)). Fixes element-hq#23794.
* Fix form tooltip positioning ([\element-hq#9598](matrix-org/matrix-react-sdk#9598)). Fixes element-hq#22861.
* Extract Search handling from RoomView into its own Component ([\element-hq#9574](matrix-org/matrix-react-sdk#9574)). Fixes element-hq#498.
* Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)).
* [Backport staging] Fix replies to emotes not showing as inline ([\element-hq#9708](matrix-org/matrix-react-sdk#9708)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @dajohi