Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen readers are noisy and unhelpful #9747

Closed
17 of 21 tasks
turt2live opened this issue May 17, 2019 · 2 comments
Closed
17 of 21 tasks

Screen readers are noisy and unhelpful #9747

turt2live opened this issue May 17, 2019 · 2 comments
Assignees
@turt2live
Labels
A11y P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Blocked
Milestone
Accessibility Imp...

Comments

@turt2live
Copy link
Member

turt2live commented May 17, 2019 •
edited by t3chguy
Loading

Many of these are duplicate of other issues, however I'm going for a checklist of things which can be solved:

  • Read receipts are read out by screen readers with no context - Read receipts are noisy for screen readers #2716 - Should we add context and put the speech behind a flag?
  • NVDA says "Riot Google Chrome Document Row 1 Column 1 Edit Send a message unencrypted"
  • Message action bar is read out by screen readers
  • Messages are read out loud 3 times: once when grey (sending), once when sent, and once more for good measure. The third one has a full timestamp read out ("May 16, 2019 at 10:25 PM")
  • Screen readers read the timeline from hours out of view, and often don't include the message bodies. For example: "4:32 PM [describes message action bar] 4:33 PM [describes message action bar] ..."
  • + next to people and rooms is just labelled as "Button" (woo, so helpful)
  • Down arrows sometimes say "Button Number Matrix HQ" instead of "Button Matrix HQ" - can we get it to say "Room Matrix HQ" or something?
  • Cannot distinguish between room headers and rooms when using arrow keys to go down the list ("Button People", "Button Rooms", "Button Matrix HQ")
  • Flair is noisy ("plus matrix matrix dot org matrix core team plus matrix matrix dot org")
  • "Files button collapsed expanded files panel" when clicking on files tab
  • "Complimentary landmark TravisR button" for clicking name at top left (as welcoming as it is to be my own personal landmark)
  • Settings dialogs do not annotate tabs, cannot move between them. No idea what tab I'm on - no verbal cue
  • Device name settings doesn't make any sense with speech cues - "Desktop row 1 column 1 device table editable desktop selection negative 1 multiline editable desktop" (my device name is "Desktop") (Device Name settings are not greatly accessible #11288)
  • Switches in settings are not keyboard accessible (tab skips)
  • Setting tabs are not keyboard accessible
  • Many links and buttons are just their names, eg "restore from backup button" - restore what backup? or "here button" for a "click here" link - click for what?
  • Riot breaks through NVDA's sleep mode - can't fix
  • Hovering messages causes readers to read out timestamps
  • Readers keep reading old rooms when you've already switched several times
  • Implement Make the timeline less noisy for screen readers (mk II) matrix-org/matrix-react-sdk#3019 proper
  • Probably more...

TODO: Associate with individual issues if they already exist
TODO: Check login/registration etc
@turt2live turt2live added T-Defect ui/ux P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround I18n labels May 17, 2019
@turt2live turt2live added this to the Accessibility Improvements milestone May 17, 2019
@turt2live turt2live self-assigned this May 17, 2019
@turt2live turt2live mentioned this issue May 17, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 21, 2019
@turt2live
Add voice labels for quick add room buttons
c2c55e0 
See element-hq/element-web#9747
@turt2live turt2live mentioned this issue May 21, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Hide flair from screen readers
5ae23fd 
To have less noise when they run over the sender profile.

See element-hq/element-web#9747
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Mute avatars and read receipts on event tiles
4779144 
This reduces overall noise from the screen reader. It was reading the alt attribute from the sender avatar, which was just a mxid. The read receipts were just nonsensical noise.

Fixes element-hq/element-web#2716
Fixes element-hq/element-web#5697
See element-hq/element-web#9747
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Mute timestamps for irrelevant updates
68c4ee9 
Other fix for element-hq/element-web#5697

See element-hq/element-web#9747
@turt2live turt2live mentioned this issue May 22, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Hide flair from screen readers
85a0241 
To have less noise when they run over the sender profile.

See element-hq/element-web#9747
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Mute avatars and read receipts on event tiles
6edf760 
This reduces overall noise from the screen reader. It was reading the alt attribute from the sender avatar, which was just a mxid. The read receipts were just nonsensical noise.

Fixes element-hq/element-web#2716
Fixes element-hq/element-web#5697
See element-hq/element-web#9747
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Mute timestamps for irrelevant updates
8f6884e 
Other fix for element-hq/element-web#5697

See element-hq/element-web#9747
@turt2live turt2live mentioned this issue May 22, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Label message edit field as such for screen readers
a551ef1 
See element-hq/element-web#9747
@turt2live turt2live mentioned this issue May 22, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Always mute timestamp from screen readers
c55f083 
The short time is still read out (eg: 15:24), however by ignoring the anchor we prevent the reader from saying the title of the containing span. This prevents readers saying "Wed May 22, 2019 at 15:24 15:24".

See element-hq/element-web#9747
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 22, 2019
@turt2live
Fix events not being spoken in the most complicated way possible
09d195b 
There's details in the comment body of this diff.

See element-hq/element-web#9747
This was referenced Sep 17, 2019
Closed
Open
@t3chguy
Copy link
Member

t3chguy commented Nov 1, 2019

"Files button collapsed expanded files panel" when clicking on files tab

is now "Files Tab 2 of 3" then "Selected"

@MarcoZehe MarcoZehe mentioned this issue Feb 12, 2020
Merged
@Palid Palid mentioned this issue Dec 14, 2021
Closed
@t3chguy t3chguy mentioned this issue Dec 15, 2021
Closed
@duxovni
Copy link
Contributor

duxovni commented Apr 20, 2022

This issue is pretty old, and at least a couple of the outstanding sub-issues on the checklist seem possibly fixed or no longer relevant. I'll close this, and we can open new issues for screen reader accessibility issues that are still present, perhaps with #20099 as a starting point.

@duxovni duxovni closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A11y P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Blocked
Projects
None yet
Milestone
Accessibility Improvements
Development

No branches or pull requests
4 participants
@jryans @turt2live @t3chguy @duxovni