-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ElectronPlatform: Add support for a event index using Seshat. #11125
Changes from 17 commits
1dbdd0a
71023ae
94196eb
a6839af
c3c5756
449eca6
437c59f
e9352fc
b90a94b
7147af8
dd2c210
076bf6f
0813aff
b17a403
4a25252
73b302f
137bedb
2f2cbad
d0b5391
e96c44c
4c629e8
da4b403
b52141d
5f6636e
b1aff29
40f2648
f0fe968
5b8e918
1869350
b0783a8
f28f27a
e5956de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,11 +5,16 @@ | |
"version": "1.4.2", | ||
"description": "A feature-rich client for Matrix.org", | ||
"author": "New Vector Ltd.", | ||
"scripts": { | ||
"build": "electron-build-env --electron 6.0.3 neon build seshat-node --release", | ||
"postinstall": "yarn build" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, so this is just to call the line above...? |
||
}, | ||
"dependencies": { | ||
"auto-launch": "^5.0.1", | ||
"electron-store": "^2.0.0", | ||
"electron-window-state": "^4.1.0", | ||
"minimist": "^1.2.0", | ||
"png-to-ico": "^1.0.2" | ||
"png-to-ico": "^1.0.2", | ||
"matrix-seshat": "^0.3.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume there will more be changes to move this to documentation in some way? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I wanna leave it in until it's ready to be merged in case a curious soul wants to try the PR out. |
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,8 @@ | |
"feature_sas": "labs", | ||
"feature_room_breadcrumbs": "labs", | ||
"feature_state_counters": "labs", | ||
"feature_many_integration_managers": "labs" | ||
"feature_many_integration_managers": "labs", | ||
"feature_event_indexing": "labs" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
}, | ||
"welcomeUserId": "@riot-bot:matrix.org", | ||
"piwik": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really try hard to find a way to build that doesn't duplicate the Electron version in another place, as we'll surely forget to keep them synchronised. Maybe we need a wrapper script to pull it out of the main
package.json
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing doesn't even work with the version passed as is. It seems to be only necessary if you need to rebuild seshat for some reason (e.g. if you're linking it from your dev folder) anyways.
Since we're adding run-time checks for seshat anyways it will be safe to remove it as well.