Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces keyboard shortcuts first cut #17457

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Spaces keyboard shortcuts first cut #17457

merged 3 commits into from
Jun 22, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 24, 2021 •
edited
Loading

@t3chguy t3chguy requested a review from a team May 24, 2021 17:23
jryans
jryans approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to try as long as it's desktop only. Should Product review as well?

@t3chguy
Copy link
Member Author

t3chguy commented May 25, 2021

It was instigated by Nad but sure, not in any rush for it to land

@t3chguy t3chguy requested a review from a team May 25, 2021 11:01
@nadonomy nadonomy self-requested a review June 17, 2021 10:48
nadonomy
nadonomy suggested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually sorry, @t3chguy is it trivial to make 0 act as Home/all instead? and then 1-9 for Spaces?

@t3chguy
Copy link
Member Author

t3chguy commented Jun 17, 2021

@nadonomy sure, even more trivial than the implementation I have but wouldn't it feel weird for them to be in a different order?

On screen they'd be

Home, Space 1, Space 2, etc
on keyboard they'd be
Space 1, Space 2, Space 3, ... Space 9, Home

@nadonomy
Copy link
Contributor

@nadonomy sure, even more trivial than the implementation I have but wouldn't it feel weird for them to be in a different order?

I see the concern, but I don't think the keyboard shortcuts need to have as binary a relationship to the list. For example, in Figma 1-9 are for docs, skipping 'Home' entirely:

Screenshot 2021-06-17 at 12 23 58

I'd rather start here to test that first, as I'm also thinking ahead on further visual iteration and interactions we'll do on the space panel in future. It'll be tough to change if people build muscle memory which isn't congruent with the overall direction.

Can we start here first, and iterate? Or perhaps throw in a labs flag with this as the default but allow us to dogfood both internally/in the beta?

@t3chguy t3chguy requested a review from nadonomy June 18, 2021 07:24
@t3chguy t3chguy merged commit 1805a28 into develop Jun 22, 2021
@t3chguy t3chguy deleted the t3chguy/fix/17128-1 branch June 22, 2021 13:21
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jul 17, 2021
@Midar
Update chat/element-web to 1.7.32
33780a6 
Changes in [1.7.32](https://github.com/vector-im/element-web/releases/tag/v1.7.32) (2021-07-05)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.32-rc.1...v1.7.32)

 * No changes from rc.1

Changes in [1.7.32-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.32-rc.1) (2021-06-29)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.31...v1.7.32-rc.1)

 * Update to react-sdk v3.25.0-rc.1 and js-sdk v12.0.1-rc.1
 * Translations update from Weblate
   [\#17832](element-hq/element-web#17832)
 * Fix canvas-filter-polyfill mock path
   [\#17785](element-hq/element-web#17785)
 * Mock context-filter-polyfill for app-tests
   [\#17774](element-hq/element-web#17774)
 * Add libera.chat to default room directory
   [\#17772](element-hq/element-web#17772)
 * Improve typing of Event Index Manager / Seshat
   [\#17704](element-hq/element-web#17704)
 * Bump dns-packet from 1.3.1 to 1.3.4
   [\#17478](element-hq/element-web#17478)
 * Update matrix-widget-api to fix build issues
   [\#17747](element-hq/element-web#17747)
 * Fix whitespace in Dockerfile
   [\#17742](element-hq/element-web#17742)
 * Upgrade @types/react and @types/react-dom
   [\#17723](element-hq/element-web#17723)
 * Spaces keyboard shortcuts first cut
   [\#17457](element-hq/element-web#17457)
 * Labs: feature_report_to_moderators
   [\#17694](element-hq/element-web#17694)

Changes in [1.7.31](https://github.com/vector-im/element-web/releases/tag/v1.7.31) (2021-06-21)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.31-rc.1...v1.7.31)

 * Upgrade to React SDK 3.24.0 and JS SDK 12.0.0

Changes in [1.7.31-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.31-rc.1) (2021-06-15)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.30...v1.7.31-rc.1)

 * Upgrade to React SDK 3.24.0-rc.1 and JS SDK 12.0.0-rc.1
 * Translations update from Weblate
   [\#17655](element-hq/element-web#17655)
 * Upgrade matrix-react-test-utils for React 17 peer deps
   [\#17653](element-hq/element-web#17653)
 * Fix lint errors in Webpack config
   [\#17626](element-hq/element-web#17626)
 * Preload only `woff2` fonts
   [\#17614](element-hq/element-web#17614)
 * ⚛️ Upgrade to React@17
   [\#17601](element-hq/element-web#17601)

Changes in [1.7.30](https://github.com/vector-im/element-web/releases/tag/v1.7.30) (2021-06-07)
===============================================================================================
[Full Changelog](element-hq/element-web@v1.7.30-rc.1...v1.7.30)

 * Upgrade to React SDK 3.23.0 and JS SDK 11.2.0

Changes in [1.7.30-rc.1](https://github.com/vector-im/element-web/releases/tag/v1.7.30-rc.1) (2021-06-01)
=========================================================================================================
[Full Changelog](element-hq/element-web@v1.7.29...v1.7.30-rc.1)

 * Upgrade to React SDK 3.23.0-rc.1 and JS SDK 11.2.0-rc.1
 * Translations update from Weblate
   [\#17526](element-hq/element-web#17526)
 * Add Modernizr test for Promise.allSettled given js-sdk and react-sdk depend
   on it
   [\#17464](element-hq/element-web#17464)
 * Bump libolm dependency, and update package name.
   [\#17433](element-hq/element-web#17433)
 * Remove logo spinner
   [\#17423](element-hq/element-web#17423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadonomy nadonomy nadonomy approved these changes

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @nadonomy @jryans