Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a screenshots page that will allow us to do screenshot testing #20417

Closed
wants to merge 3 commits into from

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Jan 6, 2022

As discussed quite a while ago, our CONTRIBUTING guide mentions screenshot tests, but we don't have a way of doing that yet.

This adds a page called screenshots.html that renders fixed versions of different components when we choose them.

Future work in matrix-react-sdk will allow us to:

  • create PNG screenshots of each component on screenshots.html
  • compare them with references

This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Tasks for the team like planning label Jan 6, 2022
@andybalaam andybalaam requested a review from a team as a code owner January 6, 2022 10:53
@turt2live
Copy link
Member

should this be at this level, or in the react-sdk?

@andybalaam
Copy link
Contributor Author

should this be at this level, or in the react-sdk?

I could not see how to do this (make a new page like this) in react-sdk. If you can point me in the right direction, I'd be happy to do that.

@turt2live
Copy link
Member

it'll almost certainly require infrastructure to be created to support it, but ultimately we're not testing Element we're testing the React SDK, so should be somewhere in there.

@andybalaam
Copy link
Contributor Author

it'll almost certainly require infrastructure to be created to support it, but ultimately we're not testing Element we're testing the React SDK, so should be somewhere in there.

OK, closing this PR so I can work on one in matrix-react-sdk

@andybalaam andybalaam closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants