Switch container image to nginx-unprivileged #20627
Open
+8
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take on #17927 which was reverted in #17990. I'm approaching this by using the alpine version of the [official nginx-unprivileged image]
Fixes #25926
(https://hub.docker.com/r/nginxinc/nginx-unprivileged) which uses port 8080 by default.
Why use an unprivileged container?
Changes in this PR:
nginxinc/nginx-unprivileged
/app
8080
I understand that there might be concern that changing the container port could break existing deployments. I can see multiple ways to deal with this:
v1.9.9
andv1.9.9-unprivileged
. Optionally, there could be a deprecation phase after which there won't be any root-versions anymore.This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is, or addType: [enhancement/defect/task]
to the description and I'll add them for you.