Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock to /versions API endpoint #21380

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Add mock to /versions API endpoint #21380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05583e1
Add mock to /versions API endpoint
Mar 10, 2022
ac3b0e5
make versions call expected for guests
Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/app-tests/joining-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ describe('joining a room', function() {
const ROOM_ALIAS = '#alias:localhost';
const ROOM_ID = '!id:localhost';

httpBackend.when('GET', '/capabilities').respond(200, { capabilities : {} });
httpBackend.when('GET', '/pushrules').respond(200, {});
httpBackend.when('POST', '/filter').respond(200, { filter_id: 'fid' });

Expand Down
22 changes: 7 additions & 15 deletions test/app-tests/loading-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,15 @@ describe('loading:', function() {
// returns a promise resolving to the received request
async function expectAndAwaitSync(opts?) {
let syncRequest = null;
httpBackend.when('GET', '/_matrix/client/versions')
.respond(200, {
"versions": ["r0.3.0"],
"unstable_features": {
"m.lazy_load_members": true
}
});
const isGuest = opts && opts.isGuest;
if (!isGuest) {
httpBackend.when('GET', '/_matrix/client/versions')
.respond(200, {
"versions": ["r0.3.0"],
"unstable_features": {
"m.lazy_load_members": true
}
});
// the call to create the LL filter
httpBackend.when('POST', '/filter').respond(200, { filter_id: 'llfid' });
}
Expand Down Expand Up @@ -313,7 +313,6 @@ describe('loading:', function() {
});

it('shows the last known room by default', function() {
httpBackend.when('GET', '/capabilities').respond(200, { capabilities: {} });
httpBackend.when('GET', '/pushrules').respond(200, {});

loadApp();
Expand All @@ -333,7 +332,6 @@ describe('loading:', function() {
it('shows a home page by default if we have no joined rooms', function() {
localStorage.removeItem("mx_last_room_id");

httpBackend.when('GET', '/capabilities').respond(200, { capabilities : {} });
httpBackend.when('GET', '/pushrules').respond(200, {});

loadApp();
Expand All @@ -351,7 +349,6 @@ describe('loading:', function() {
});

it('shows a room view if we followed a room link', function() {
httpBackend.when('GET', '/capabilities').respond(200, { capabilities : {} });
httpBackend.when('GET', '/pushrules').respond(200, {});

loadApp({
Expand Down Expand Up @@ -425,7 +422,6 @@ describe('loading:', function() {

describe('Guest auto-registration:', function() {
it('shows a welcome page by default', function() {
httpBackend.when('GET', '/capabilities').respond(200, { capabilities: {} });

loadApp();

Expand Down Expand Up @@ -457,7 +453,6 @@ describe('loading:', function() {
});

it('uses the default homeserver to register with', function() {
httpBackend.when('GET', '/capabilities').respond(200, { capabilities: {} });

loadApp();

Expand Down Expand Up @@ -493,7 +488,6 @@ describe('loading:', function() {
});

it('shows a room view if we followed a room link', function() {
httpBackend.when('GET', '/capabilities').respond(200, { capabilities: {} });

loadApp({
uriFragment: "#/room/!room:id",
Expand Down Expand Up @@ -526,7 +520,6 @@ describe('loading:', function() {

describe('Login as user', function() {
beforeEach(function() {
httpBackend.when('GET', '/capabilities').respond(200, { capabilities: {} });

// first we have to load the homepage
loadApp();
Expand Down Expand Up @@ -674,7 +667,6 @@ describe('loading:', function() {
// Wait for another trip around the event loop for the UI to update
return sleep(1);
}).then(() => {
httpBackend.when('GET', '/capabilities').respond(200, { capabilities : {} });
httpBackend.when('GET', '/pushrules').respond(200, {});
return expectAndAwaitSync().catch((e) => {
throw new Error("Never got /sync after login: did the client start?");
Expand Down