Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a script to check for dead code #22793

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Add a script to check for dead code #22793

merged 3 commits into from
Jul 13, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jul 10, 2022 •
edited by github-actions bot
Loading

Towards #21969

This change is marked as an internal change (Task), so will not be included in the changelog.

@SimonBrandner
Add ts-prune
5d9522b 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner
Add prune:code
10b17fd 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner added the T-Task Tasks for the team like planning label Jul 10, 2022
@SimonBrandner SimonBrandner requested a review from a team as a code owner July 10, 2022 09:37
weeman1337
weeman1337 reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Some minor things (see my comments).

scripts/prune_code.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@SimonBrandner
Apply code review suggestions
dca1f32 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner requested review from weeman1337 and removed request for justjanne and robintown July 11, 2022 06:16
@SimonBrandner SimonBrandner enabled auto-merge (squash) July 13, 2022 07:54
weeman1337
weeman1337 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SimonBrandner SimonBrandner merged commit e1d4817 into develop Jul 13, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/task/ts-prune branch July 13, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBrandner @weeman1337