Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform more of the codebase with noImplicitAny and strictNullChecks (#25174 #25174

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 21, 2023

Requires matrix-org/matrix-react-sdk#10691
For #23542


This change is marked as an internal change (Task), so will not be included in the changelog.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Apr 21, 2023
@t3chguy t3chguy marked this pull request as ready for review April 21, 2023 13:45
@t3chguy t3chguy requested review from a team as code owners April 21, 2023 13:45
@t3chguy t3chguy self-assigned this Apr 21, 2023
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good!


// We return here because startSingleSignOn() will asynchronously redirect us. We don't
// care to wait for it, and don't want to show any UI while we wait (not even half a welcome
// page). As such, just don't even bother loading the MatrixChat component.
return;
return <></>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a nitpick and feel free to leave that one out. But I feel like <React.Fragment /> reads a bit better than the above

src/vector/app.tsx Outdated Show resolved Hide resolved
@t3chguy t3chguy changed the title Conform more of the codebase with noImplicitAny and strictNullChecks Conform more of the codebase with noImplicitAny and strictNullChecks (#25174 Apr 25, 2023
@t3chguy t3chguy merged commit f5b8bcc into develop Apr 25, 2023
@t3chguy t3chguy deleted the t3chguy/types101 branch April 25, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants