Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error notification audio #25312

Merged
merged 1 commit into from
May 10, 2023
Merged

Add error notification audio #25312

merged 1 commit into from
May 10, 2023

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented May 9, 2023 •
edited
Loading

should be merged before matrix-org/matrix-react-sdk#10654

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Tasks for the team like planning label May 9, 2023
@weeman1337 weeman1337 mentioned this pull request May 9, 2023
Merged
3 tasks
@weeman1337 weeman1337 marked this pull request as ready for review May 9, 2023 09:52
@weeman1337 weeman1337 requested a review from a team as a code owner May 9, 2023 09:52
andybalaam
andybalaam approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@richvdh richvdh removed their request for review May 9, 2023 16:53
@weeman1337 weeman1337 merged commit b25a7ef into develop May 10, 2023
@weeman1337 weeman1337 deleted the weeman1337/error-audio branch May 10, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @andybalaam