Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: document config #26400

Merged
merged 3 commits into from
Oct 19, 2023
Merged

OIDC: document config #26400

merged 3 commits into from
Oct 19, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Oct 18, 2023 •
edited by github-actions bot
Loading

Closes https://github.com/vector-im/element-internal/issues/461

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Tasks for the team like planning label Oct 18, 2023
@kerryarchibald kerryarchibald requested a review from a team as a code owner October 18, 2023 21:19
germain-gg
germain-gg approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@richvdh richvdh removed their request for review October 19, 2023 12:42
@kerryarchibald kerryarchibald enabled auto-merge (squash) October 19, 2023 23:43
@kerryarchibald kerryarchibald merged commit 80ba22a into develop Oct 19, 2023
15 checks passed
@kerryarchibald kerryarchibald deleted the kerry/oidc-document-config branch October 19, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @germain-gg