Fix element-desktop-ssoid being included in OIDC Authorization call
#27431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
richvdh
approved these changes
May 10, 2024
|
[I don't think I really meant to give this a green tick yet; I'd like to hear your thoughts on a separate method first. But if you want to go ahead and merge as-is, that's ok] |
Yeah separate method is a good call, just come out of an Auth meeting where the legacy and OIDC flows diverged even more so good timing. |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
richvdh
reviewed
May 13, 2024
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#12495
Requires element-hq/element-desktop#1662