Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport staging] Switch to secure random strings #29035

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

RiotRobot
Copy link
Contributor

Backport 56eafc9 from #29013.

* Switch to secure random strings

Because the js-sdk methods are changing and there's no reason for these
not to use the secure versions. The dedicated upper/lower functions were
*only* used in this one case, so this should do the exact same thing with
the one exported function.

Requires matrix-org/matrix-js-sdk#4621 (merge both together)

* Change remaining instances of randomString

which I somehow entirely missed the first time.

* Fix import order

(cherry picked from commit 56eafc9)
@RiotRobot RiotRobot requested a review from a team as a code owner January 21, 2025 15:06
@RiotRobot RiotRobot requested review from dbkr and t3chguy January 21, 2025 15:06
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 21, 2025
@t3chguy t3chguy enabled auto-merge January 21, 2025 15:06
@t3chguy t3chguy added this pull request to the merge queue Jan 21, 2025
Merged via the queue into staging with commit 1e1d669 Jan 21, 2025
38 of 42 checks passed
@t3chguy t3chguy deleted the backport-29013-to-staging branch January 21, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect X-Release-Blocker Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants