Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New room list: add search section #29251

Merged
merged 12 commits into from
Feb 13, 2025

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Feb 12, 2025

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task https://github.com/element-hq/wat-internal/issues/204
Figma design

This PR adds the search section of the new room list.

  • Move RoomListView into src/components/views/rooms/RoomListView folder. We will have many components for the new room list and we can put them in a dedicated folder.
  • Add the new search section
    • Click on the search button opens the spotlight
    • Click on the explore button opens the public room directory
    • The explore button is only available in Home meta space
    • Open spotlight when focus_room_filter is fired. Behaviour in legacy/current room list:
      private dispatcherRef?: string;
      public componentDidMount(): void {
      this.dispatcherRef = defaultDispatcher.register(this.onAction);
      }
      public componentWillUnmount(): void {
      defaultDispatcher.unregister(this.dispatcherRef);
      }
      private openSpotlight(): void {
      defaultDispatcher.fire(Action.OpenSpotlight);
      }
      private onAction = (payload: ActionPayload): void => {
      if (payload.action === "focus_room_filter") {
      this.openSpotlight();
      }
      };
      • In my option this should be moved in the incoming view model when implemented.
      • PR to remove it
    • The dial button is still in discussion (can be added later easily)
    • There is not yet design when the room list size is reduced
  • e2e: add a method to close notification toast
  • e2e: add tests for the search section
  • e2e: the tests for the new room list is quite empty but should be completed with incoming PRs adding new content to the new room list.

User interactions

Screen.Recording.2025-02-13.at.10.48.55.mov

@florianduros florianduros force-pushed the florianduros/new-room-list/search-component branch from ecc302f to 92200e2 Compare February 12, 2025 15:20
@florianduros florianduros changed the title Add search section to new room list New room list: add search section Feb 12, 2025
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Has wrapping/scaling issues

Comment on lines 28 to 30
span {
display: flex;
justify-content: space-between;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not use our semantic Flex component instead?

@florianduros
Copy link
Member Author

florianduros commented Feb 13, 2025

@t3chguy The "responsiveness" of the new room list is still in discussion. We don't have visual and spec yet.

We can add it later, the new room list is behind a labs flag

@florianduros
Copy link
Member Author

FYI, I opened #29259 to get rid of focus_room_filter action.

@florianduros florianduros added this pull request to the merge queue Feb 13, 2025
Merged via the queue into develop with commit 2abd534 Feb 13, 2025
31 checks passed
@florianduros florianduros deleted the florianduros/new-room-list/search-component branch February 13, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants