Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EditInPlace control for Identity Server picker to improve a11y #29280

Merged
merged 18 commits into from
Feb 21, 2025
Merged

Use EditInPlace control for Identity Server picker to improve a11y #29280

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3a0cffe
Use EditInPlace for identity server picker.
Half-Shot Feb 17, 2025
02ffc77
Exclude picker from default dialog button styles.
Half-Shot Feb 17, 2025
35700c6
Remove unused import.
Half-Shot Feb 17, 2025
574b6db
Update test
Half-Shot Feb 17, 2025
3f39189
Remove unused css
Half-Shot Feb 17, 2025
48e3445
Update test
Half-Shot Feb 17, 2025
a2c411d
drop only
Half-Shot Feb 17, 2025
29647c9
Add a test for setting an ID server.
Half-Shot Feb 17, 2025
05b7812
Merge branch 'develop' into hs/identity-server-picker-modernize
Half-Shot Feb 17, 2025
24a0453
Add a unit test for SetIdServer
Half-Shot Feb 17, 2025
73d382d
fix tests
Half-Shot Feb 17, 2025
397b792
Reformat mx_Dialog button :not list to use a more readable selector.
Half-Shot Feb 18, 2025
5ed4e10
Reformat other :not sections
Half-Shot Feb 18, 2025
84e698e
forgot a comma
Half-Shot Feb 18, 2025
1fa1048
We're in 2025 now.
Half-Shot Feb 18, 2025
80e5cfa
Update copyright + use class methods.
Half-Shot Feb 18, 2025
0c4655c
Merge branch 'develop' into hs/identity-server-picker-modernize
Half-Shot Feb 21, 2025
ab4fdeb
Merge branch 'develop' into hs/identity-server-picker-modernize
Half-Shot Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions playwright/e2e/settings/security-user-settings-tab.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ test.describe("Security user settings tab", () => {
});
});

test("should contain section to set ID server", async ({ app }) => {
test.only("should contain section to set ID server", async ({ app }) => {
const tab = await app.settings.openUserSettings("Security");

const setIdServer = tab.locator(".mx_SetIdServer");
const setIdServer = tab.locator(".mx_IdentityServerPicker");
await setIdServer.scrollIntoViewIfNeeded();
// Assert that an input area for identity server exists
await expect(setIdServer.getByRole("textbox", { name: "Enter a new identity server" })).toBeVisible();
Expand Down
1 change: 0 additions & 1 deletion res/css/_components.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@
@import "./views/settings/_PowerLevelSelector.pcss";
@import "./views/settings/_RoomProfileSettings.pcss";
@import "./views/settings/_SecureBackupPanel.pcss";
@import "./views/settings/_SetIdServer.pcss";
@import "./views/settings/_SetIntegrationManager.pcss";
@import "./views/settings/_SettingsFieldset.pcss";
@import "./views/settings/_SettingsHeader.pcss";
Expand Down
23 changes: 0 additions & 23 deletions res/css/views/settings/_SetIdServer.pcss
View file
Open in desktop

This file was deleted.

Loading