Room List Store: Support filters by implementing just the favourite filter #29433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Holds data to indicate which filters apply - Provides method to check if a given set of filters apply to this node - Provides a method to recalculate which filters apply
t3chguy
approved these changes
Mar 6, 2025
Comment on lines
37
to
41
| while (current) { | ||
| if (current.isInActiveSpace && current.doesRoomMatchFilters(this.filters)) break; | ||
| else current = current.next[0]; | ||
| } | ||
| if (!current) return { value: undefined, done: true }; |
There was a problem hiding this comment.
The code style here doesn't really match the rest of the codebase
There was a problem hiding this comment.
if conditions without braces?
There was a problem hiding this comment.
still not sure what the code style actually is though. Our code_Style.md says:
When a statement's body is a single line, it must be written without curly braces, so long as the body is placed on the same line as the statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only implements the favourite filter.