New room list: add more options menu on room list item #29445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
from
41f682f to
ffefe93
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
2 times, most recently
from
d33ceb3 to
47bc7a5
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
from
47bc7a5 to
4739790
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
from
4739790 to
15d4e26
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
from
15d4e26 to
1789e71
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
3 times, most recently
from
97ee10c to
2b711cc
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
2 times, most recently
from
c45eb54 to
f58e76f
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
from
f58e76f to
ecdac1c
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
from
8ba459f to
28f9922
Compare
florianduros
force-pushed
the
florianduros/new-room-list/hover-menu
branch
from
28f9922 to
41f6eb9
Compare
dbkr
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
Figma design
This PR adds the more options menu in the new room list. The button to open the menu appears on the hover of a room list item.
RoomListCellintoRoomListItemView. Added the view suffix because a view model is added.RoomListItemis more suitable thanRoomListCellopenRoomaction from the view model list to the view model of the room list itemIn terms of a11y, a dedicated phase will be done when the room list item will be complete. We have two nested buttons which is a wrong pattern and we need to elaborate a strategy how to navigate with a keyboard.
Menu in action
Screen.Recording.2025-03-12.at.12.36.31.mov