Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomListViewModel: Support secondary filters in the view model #29465

Merged
merged 4 commits into from
Mar 11, 2025
Merged

RoomListViewModel: Support secondary filters in the view model #29465

merged 4 commits into from
Mar 11, 2025

Conversation

MidhunSureshR
Copy link
Member

@MidhunSureshR MidhunSureshR commented Mar 11, 2025 •
edited
Loading

  • The vm exposes activateSecondaryFilter which can be called to change the secondary filter.
  • The vm exposes activeSecondaryFilter which tells you the currently active secondary filer.

@MidhunSureshR MidhunSureshR marked this pull request as ready for review March 11, 2025 11:41
@MidhunSureshR MidhunSureshR requested a review from a team as a code owner March 11, 2025 11:41
@MidhunSureshR MidhunSureshR requested review from dbkr and t3chguy March 11, 2025 11:41
dbkr
dbkr approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, really liking how this is coming out: feels quite modular and simple. Also the small PRs are quite easy to review - thank you!

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Mar 11, 2025
Merged via the queue into develop with commit 3f3fba9 Mar 11, 2025
38 checks passed
@MidhunSureshR MidhunSureshR deleted the midhun/rls/vm-filters-2 branch March 11, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MidhunSureshR @dbkr