New room list: add primary filters #29481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/new-room-list/primary-filters
branch
from
0599601 to
3bb2bdd
Compare
florianduros
force-pushed
the
florianduros/new-room-list/primary-filters
branch
from
3bb2bdd to
1790fa3
Compare
florianduros
force-pushed
the
florianduros/new-room-list/primary-filters
branch
from
2ef37b8 to
085e32d
Compare
t3chguy
reviewed
Mar 13, 2025
src/i18n/strings/en_EN.json
Outdated
| @@ -2114,6 +2114,7 @@ | |||
| "list_title": "Room list", | |||
| "notification_options": "Notification options", | |||
| "open_space_menu": "Open space menu", | |||
| "primary_filters": "Room list primary filters", | |||
There was a problem hiding this comment.
This sounds like jargon, I don't think "primary filter" should be exposed to users
There was a problem hiding this comment.
Right, Room list filters is enough
t3chguy
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
Figma design
Add the unread, room, people and favourites filters to the new room list.
Filters
Screen.Recording.2025-03-12.at.18.17.04.mov