Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room List Store: Save preferred sorting algorithm and use that on app launch #29493

Merged
merged 6 commits into from
Mar 14, 2025
Merged

Room List Store: Save preferred sorting algorithm and use that on app launch #29493

merged 6 commits into from
Mar 14, 2025

Conversation

MidhunSureshR
Copy link
Member

@MidhunSureshR MidhunSureshR commented Mar 14, 2025 •
edited
Loading

  • Adds a device level setting that stores the user's sorting preference.
  • Adds a type property to the sorter so that it can be uniquely identified.
  • Replace useAlphabeticSorting() and useRecencySorting() with a single resort(type) method.
  • RLS will use the preferred sorter at start .

@MidhunSureshR
Add type property to Sorter
f64baca 
So that we can uniquely identify any given sorting algorithm.
@MidhunSureshR
Add a getter for the active sort algorithm
317f9f2
@MidhunSureshR
Define a setting to store the sorting algorithm
1f12e83
@MidhunSureshR
Add a method to resort the list of rooms
ea9bc86 
- Just one method where you specify the sorting algorithm by type.
- Persist the new sorting algorithm using SettingsStore.
@MidhunSureshR
On startup, use preferred sorter
c8b8080
@MidhunSureshR
Add tests
0a942f3
@MidhunSureshR MidhunSureshR marked this pull request as ready for review March 14, 2025 05:28
@MidhunSureshR MidhunSureshR requested a review from a team as a code owner March 14, 2025 05:28
dbkr
dbkr approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice API.

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Mar 14, 2025
Merged via the queue into develop with commit f4b03a1 Mar 14, 2025
44 of 48 checks passed
@MidhunSureshR MidhunSureshR deleted the midhun/rls/save-preferred-sort branch March 14, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MidhunSureshR @dbkr