Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: flip local video feed by default #29501

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jbtrystram
Copy link

Most (if not all) video chat apps show my local video mirrored. Element not doing it by default is makes it confusing at first. Even my phone camera app does it.

Not only matching other video chat tools out there, 99% of times you see yourself in your day to day life is through a mirror, which flips the image. So matching that makes the most sense, to preserve continuity.

This setting was made optional in #5437 but not defaulted to true.

Fixes #10651

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Most (if not all) video chat apps show my local video mirrored. Element
not doing it by default is makes it confusing at first.
Even my phone camera app does it.

Not only matching other video chat tools out there, 99% of times you see
yourself in your day to day life is through a mirror, which flips the
image. So matching that makes the most sense, to preserve continuity.

This setting was made optional in element-hq#5437
but not defaulted to true.

Fixes element-hq#10651
@jbtrystram jbtrystram requested a review from a team as a code owner March 14, 2025 15:06
@jbtrystram jbtrystram requested review from dbkr and florianduros March 14, 2025 15:06
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Mar 14, 2025
Copy link

@yuguen-intel yuguen-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbkr
Copy link
Member

dbkr commented Mar 14, 2025

There was some contention on this when it was introduced so this should probably be a product decision. That said, this will only be for legacy 1:1 calls anyway, and EC mirrors the local video feed with no option (although is smart enough to only do it for front-facing ones).

@dbkr dbkr added the X-Needs-Product More input needed from the Product team label Mar 14, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-Needs-Product More input needed from the Product team Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Mirror local video feed" should be on by default
4 participants