Fix bug which caused startup to hang if the clock was wound back since a previous session #29558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 seconds staring at a spinner while we wait for a stale lock to expire is rather painful. Pretty sure 15 seconds will be fine.
If a previous session terminated uncleanly, and then the clock is wound back, we could be waiting a very long time for the previous session's claim to expire. We can fix this by simply treating a future claim the same as "now", and waiting for the normal stale timeout.
richvdh
changed the title
t3chguy
reviewed
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a previous session terminated uncleanly, and then the clock is wound back, we could be waiting a very long time for the previous session's claim to expire.
We can fix this by simply treating a future claim the same as "now", and waiting for the normal stale timeout.
We also reduce the "stale" timeout from 30 seconds to 15 seconds, to reduce the amount of time we sit looking at a spinner.
Fixes: #28168