Restore People/Favourites metaspaces #30881
Open
+344
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
|
Code-wise looks fine but needs product sign off to continue |
|
Actually, upon testing, this doesn't seem to return either of the setting pages necessary to enable those metaspaces, so this would only work for users which already have those metaspaces enabled. |
Good point, should've thought of that. EDIT: Done |
|
|
|
Are there any tests I'd have to update for this? I haven't checked whether the new room list changes also affected the E2E tests yet. EDIT: Found them. |
justjanne
force-pushed
the
labs/roomlist-metaspaces
branch
from
bb95b99 to
27324c7
Compare
justjanne
force-pushed
the
labs/roomlist-metaspaces
branch
from
27324c7 to
a80b5dc
Compare
justjanne
force-pushed
the
labs/roomlist-metaspaces
branch
from
a80b5dc to
f881ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30861
In Short
This PR restores the "People" and "Favourites" metaspaces for the new room list.
Until this gets merged, I'll maintain
k8r.eu/justjanne/element-web:v1.12.0k8r.eu/justjanne/element-web:developRationale
Many group chat apps have a separate view just for DMs. Discord calls this "Friends" (vs "Servers"), Teams calls this "Chats" (vs "Teams"), Slack introduced the "DMs" view in 2023 (vs "Channels").
Many people rely on this feature, and so do I.
Checklist
public/exportedsymbols have accurate TSDoc documentation.