stage-1 rebrand vector->riot

[t3chguy]

for #3613

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

[dbkr]

Personally, I'm very much in favour of the internal codename remaining as vector: I don't see any value in renaming non-user facing internals to match the brand: it will be another way to introduce bugs.

Edit: having read the bug, it's talking about renaming the release tarball which is a thing we probably should do.

[t3chguy]

@dbkr thats fair enough, I'm of a similar mindset, @lampholder seems of different opinion

[ara4n]

yes, please let's not waste time doing s/Vector/Riot/ on all the classes and variable names. (Just as most of macOS's internal API prefixes are still NS for NextStep... :D). Agreed that user-facing tarballs etc should be named correctly though.

[t3chguy]

@ara4n so you just want the https://github.com/vector-im/riot-web/pull/3798/files#diff-188acaa55654fd2e210e1da372302214 (scripts/package.sh) changes?

[lampholder]

@dbkr thats fair enough, I'm of a similar mindset, @lampholder seems of different opinion

Er, do I?

[t3chguy]

@lampholder I misread #3613 (comment)
neeeever mind

[t3chguy]

closed in favour of #3894