Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust CSS to prevent scrollbars on message panel spinner #6131

Merged
merged 4 commits into from
Feb 15, 2018
Merged

Adjust CSS to prevent scrollbars on message panel spinner #6131

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85c0b8d
Adjust CSS to prevent scrollbars on message panel spinner
lukebarnard1 Feb 13, 2018
b3bb2d2
Merge branch 'develop' into luke/fix-scrollbars-on-jump-to-first
lukebarnard1 Feb 14, 2018
7ac350e
Give mx_RoomView_messageListWrapper its `min-height: 100%` back
lukebarnard1 Feb 14, 2018
5c354dd
Fix messagePanelSpinner flex order in RightPanel
lukebarnard1 Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/skins/vector/css/matrix-react-sdk/structures/_RoomView.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ limitations under the License.
order: 2;
}

.mx_RoomView_body .mx_RoomView_messagePanelSpinner {
order: 2;
margin: auto;
}

.mx_RoomView_body .mx_RoomView_statusArea {
order: 3;
}
Expand All @@ -113,8 +118,6 @@ limitations under the License.
max-width: 960px;
margin: auto;

min-height: 100%;
Copy link
Member

@ara4n ara4n Feb 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this worries me - isn't the min-height the only thing keeping the timeline contents pushed to the bottom of the page if the room's history is just starting off?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sworn I fixed this failure mode, but it seems to have been left out again. I'll try to fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, now I remember. I made the .mx_messagePanelSpinner specifically so that mx_RoomView_messageListWrapper could happily, separately use min-height without affecting the spinner.


display: flex;

flex-direction: column;
Expand Down