Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Optimize Webpack Performance and bundle size #7772

Closed
wants to merge 14 commits into from
Closed

[DO NOT MERGE] Optimize Webpack Performance and bundle size #7772

wants to merge 14 commits into from

Commits on Mar 20, 2019

  1. Switch to building react-sdk inside of webpack and do minimal splitCh… 

    …unks
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    7b919b6 View commit details
    Browse the repository at this point in the history

  2. Make sure we always use src of react-sdk instead of lib 

    Took 19 minutes
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    c48794f View commit details
    Browse the repository at this point in the history

  3. Make sure that karma also builds react-sdk and js-sdk 

    Took 6 minutes
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    4a79fb0 View commit details
    Browse the repository at this point in the history

  4. Make sure that tests also use the react-sdk src instead of lib 

    Took 6 minutes
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    a38a884 View commit details
    Browse the repository at this point in the history

  5. Remove non existing UglifyJsPlugin import in the webpack config 

    Took 20 minutes
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    056f0f4 View commit details
    Browse the repository at this point in the history

  6. [webpack4-optimizations] Define "matrix-react-build-type" == "webpack… 

    …" in the package.json to generate correct component-index and overwrite the main resolve of react-sdk to point to the src version of index.js

Took 33 minutes
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    e7ef01f View commit details
    Browse the repository at this point in the history

  7. [webpack4-optimizations] remove matrix-react-sdk alias 

    Took 8 minutes
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    fde42fc View commit details
    Browse the repository at this point in the history

  8. [webpack4-optimizations] migrate new imports to matrix-react-sdk/src … 

    …and remove unused imports which broke lint
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    fdce95c View commit details
    Browse the repository at this point in the history

  9. [webpack4-optimizations] run matrix-react-sdk in karma preprocessors

    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    e220fed View commit details
    Browse the repository at this point in the history

  10. [webpack4-optimizations] debug print karma config as I am not able to… 

    … reproduce the errors locally
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    6ccef9a View commit details
    Browse the repository at this point in the history

  11. [webpack4-optimizations] Add babel config to webpack driectly because… 

    … of babel/babel-loader#736 (comment)
    @MTRNord
    MTRNord committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    3fda595 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. [webpack4-optimizations] fix build, upgrade babel

    @MTRNord
    MTRNord committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    3f5254c View commit details
    Browse the repository at this point in the history

  2. [webpack4-optimizations] Trigger CI

    @MTRNord
    MTRNord committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    ffd3430 View commit details
    Browse the repository at this point in the history

  3. [webpack4-optimizations] fix dependency versions

    @MTRNord
    MTRNord committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    ffa62b0 View commit details
    Browse the repository at this point in the history