Show resolved homeserver configuration on the mobile guide #9726
Conversation
This doesn't cover default_server_name because that pulls in a questionable amount of JS. See #9290
turt2live
changed the title
| let config = await getVectorConfig('..'); | ||
|
|
||
| // We manually parse the config similar to how validateServerConfig works because | ||
| // calling that function pulls in roughly 4mb of JS we don't use. |
There was a problem hiding this comment.
could move validateServerConfig to getconfig.js?
There was a problem hiding this comment.
That'd cost us 4mb of JS because it pulls in most of the react-sdk and most of the js-sdk
There was a problem hiding this comment.
to expand on that: the problem is that we use multiple webpack layers, so the 4mb consists of things like bluebird, browser-request, etc. If we had a single webpack for the 3 projects, we'd be able to dedupe/eliminate a lot of that cruft
There was a problem hiding this comment.
yep, I was just suggesting taking validateServerConfig stuff you have here and putting it into a separate file so both things can use it (the js-sdk bit would have to stay duplicated) but if there's a reason that's not an option then lgtm.
There was a problem hiding this comment.
yea, that's what I tried first and it's where the 4mb metric came from :(
The logic is slightly different in that here the goal is to resolve a homeserver as fast as possible with minimal safety whereas the validateServerConfig function tries to find a homeserver that's actually safe to use. It's not directly transferable without avoiding the js-sdk's implementation of stuff, which renders those classes nearly pointless.
Reviewer: Note that this is pointed at the .well-known feature branch, not develop. This is intentional as the feature branch is still unsafe to merge to develop.
See #9290