Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rich text editor] Fix 'text formatting' option only partially visible #1335

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Sep 14, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix issue where the "Text formatting" option is only partially visible in the composer options / attachments bottom sheet.

Motivation and context

Screenshots / GIFs

Screen_recording_20230914_164600.webm

Tests

  • Open the composer options / attachments bottom sheet.

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

@jonnyandrew jonnyandrew marked this pull request as ready for review September 14, 2023 15:48
@jonnyandrew jonnyandrew requested a review from a team as a code owner September 14, 2023 15:48
@jonnyandrew jonnyandrew requested review from ganfra and removed request for a team September 14, 2023 15:48
@ElementBot
Copy link
Collaborator

ElementBot commented Sep 14, 2023

Warnings
⚠️

features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/messagecomposer/AttachmentsBottomSheet.kt#L24 - Using a material import while also using the material3 library

Generated by 🚫 dangerJS against cd6506c

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tr9Uq8

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0f73d83) 57.83% compared to head (cd6506c) 57.83%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1335   +/-   ##
========================================
  Coverage    57.83%   57.83%           
========================================
  Files         1100     1100           
  Lines        29083    29085    +2     
  Branches      5949     5949           
========================================
+ Hits         16820    16822    +2     
  Misses        9644     9644           
  Partials      2619     2619           
Files Changed Coverage Δ
...ges/impl/messagecomposer/AttachmentsBottomSheet.kt 42.10% <100.00%> (+2.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyandrew jonnyandrew merged commit 15eb976 into develop Sep 14, 2023
14 of 15 checks passed
@jonnyandrew jonnyandrew deleted the jonny/fix-bottom-sheet-partially-visible branch September 14, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants