Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design review] Improve rich text editor UI #1315

Closed
12 tasks done
Tracked by #1940
jonnyandrew opened this issue Sep 13, 2023 · 0 comments
Closed
12 tasks done
Tracked by #1940

[Design review] Improve rich text editor UI #1315

jonnyandrew opened this issue Sep 13, 2023 · 0 comments
Assignees
@jonnyandrew
Labels
A-Rich-Text-Editor T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@jonnyandrew
Copy link
Contributor

jonnyandrew commented Sep 13, 2023 •
edited by kittykat
Loading

Summary

Issues raised during design review of the rich text editor:

Scope

Tasks
Beta Give feedback

Sign-off

  • Design sign-off on completion
    • @callumu noted that corner radius is still not correct
  • QA sign-off on completion
  • Product sign-off on completion

Stretch goals

None at this time

Out of scope
@jonnyandrew jonnyandrew mentioned this issue Sep 13, 2023
Closed
@jonnyandrew jonnyandrew added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Element X Feature A-Rich-Text-Editor labels Sep 13, 2023
@jonnyandrew jonnyandrew self-assigned this Sep 13, 2023
This was referenced Sep 13, 2023
Closed
Merged
Merged
Merged
Closed
Merged
Merged
@jonnyandrew jonnyandrew mentioned this issue Sep 28, 2023
Merged
12 tasks
jonnyandrew added a commit that referenced this issue Sep 29, 2023
@jonnyandrew
[Rich text editor] Add full screen mode (#1447)
53cf82f 
- Add full screen mode for the rich text editor (RTE). When text formatting options are enabled, the editor can be dragged to full screen.
- Remove `ConstraintLayout` from `textcomposer` module, now made much simpler now the RTE supports being called in multiple layouts matrix-org/matrix-rich-text-editor#822

- Part of element-hq/element-meta#1973
- Includes design from #1315
- Fixes #1293 (through new layout)
- Fixes #1394 (through inclusion of matrix-org/matrix-rich-text-editor#824)
- Fixes #1259 (through inclusion of matrix-org/matrix-rich-text-editor#820)

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
@jonnyandrew jonnyandrew added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonnyandrew jonnyandrew

Labels
A-Rich-Text-Editor T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittykat @jonnyandrew