Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rich text editor] Fix composer height and padding #1316

Closed
wants to merge 2 commits into from

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Fix composer padding when it has multiple lines
  • Fix composer shape when it has multiple lines

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@@ -154,7 +154,8 @@ fun TextComposer(
targetValue = roundedCornerSize,
animationSpec = tween(
durationMillis = 100,
)
),
label = "roundedCornerSizeAnimation"
Copy link
Contributor Author

@jonnyandrew jonnyandrew Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is an unrelated lint fix

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/sD31xa

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01% ⚠️

Comparison is base (4bf439d) 57.71% compared to head (a772f3d) 57.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1316      +/-   ##
===========================================
- Coverage    57.71%   57.71%   -0.01%     
===========================================
  Files         1087     1087              
  Lines        28665    28667       +2     
  Branches      5870     5870              
===========================================
+ Hits         16544    16545       +1     
- Misses        9546     9547       +1     
  Partials      2575     2575              
Files Changed Coverage Δ
...ent/android/libraries/textcomposer/TextComposer.kt 54.91% <66.66%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonnyandrew jonnyandrew deleted the jonny/rte-design-composer-height branch October 6, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant