[Rich text editor] Add full screen mode #1447
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1447 +/- ##
===========================================
+ Coverage 57.86% 58.30% +0.44%
===========================================
Files 1130 1132 +2
Lines 30079 30219 +140
Branches 6147 6189 +42
===========================================
+ Hits 17404 17619 +215
+ Misses 10065 9960 -105
- Partials 2610 2640 +30
☔ View full report in Codecov by Sentry. |
jonnyandrew
force-pushed
the
jonny/rte-full-screen
branch
from
5c86f18
to
5b702c1
Compare
| import io.element.android.features.messages.impl.attachments.Attachment | ||
| import io.element.android.libraries.textcomposer.MessageComposerMode | ||
| import io.element.android.wysiwyg.compose.RichTextEditorState | ||
| import kotlinx.collections.immutable.ImmutableList | ||
|
|
||
| @Immutable | ||
| @Stable |
There was a problem hiding this comment.
richTextEditorState is mutable
| color = ElementTheme.colors.textSecondary, | ||
| RichTextEditor( | ||
| state = state, | ||
| registerStateUpdates = !subcomposing, |
There was a problem hiding this comment.
Disable most of the editor functionality if it's just being measured for a subcomposition. This prevents it gaining focus and mutating the state.
There was a problem hiding this comment.
OK, thanks. Maybe add this comment also in the code?
|
It would be cool if there was a way to permanently enable the rich text editor instead of having to tap two things for it |
| color = ElementTheme.colors.textSecondary, | ||
| RichTextEditor( | ||
| state = state, | ||
| registerStateUpdates = !subcomposing, |
There was a problem hiding this comment.
OK, thanks. Maybe add this comment also in the code?
… jonny/rte-full-screen
… jonny/rte-full-screen
|
Kudos, SonarCloud Quality Gate passed!
|
Type of change
Content
ConstraintLayoutfromtextcomposermodule, now made much simpler now the RTE supports being called in multiple layouts [Android] Add support for subcomposition and sharing state matrix-org/matrix-rich-text-editor#822To follow in a later PR:
TextComposer.ktfile and split UI components into multiple files.Motivation and context
Screenshots / GIFs
Screen_recording_20230928_144233.webm
Checklist