Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show user pic in message action sheet #2032

Closed
VolkerJunginger opened this issue Dec 14, 2023 · 2 comments · Fixed by #2050
Closed

Always show user pic in message action sheet #2032

VolkerJunginger opened this issue Dec 14, 2023 · 2 comments · Fixed by #2050
Assignees
@bmarty
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@VolkerJunginger
Copy link

Steps to reproduce

When opening the message action sheet (long-press any massage type) either a preview of the message or the message type icon is show.

We alway want to show the senders avatar (see iOS)
image

Outcome

What did you expect?

What happened instead?

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes
@VolkerJunginger VolkerJunginger added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Dec 14, 2023
@manuroe manuroe added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Dec 15, 2023
@bmarty bmarty self-assigned this Dec 18, 2023
@bmarty
Copy link
Member

bmarty commented Dec 18, 2023

On iOS, for an image for instance:

image

@VolkerJunginger do you want us to add the user avatar and keep the thumbnail, or replace the thumbnail?

I would prefer to keep the thumbnail, but your choice.

@VolkerJunginger
Copy link
Author

Please replace the thumbnail w. the user-avatar. Thanks!

bmarty added a commit that referenced this issue Dec 18, 2023
@bmarty
Always show user avatar in message action sheet #2032
d032432
@bmarty bmarty mentioned this issue Dec 18, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Message bottom sheet: always show user avatar element-hq/element-x-android
3 participants
@bmarty @manuroe @VolkerJunginger