Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room transition animation happens twice since #2059 #2084

Closed
frebib opened this issue Dec 21, 2023 · 1 comment · Fixed by #2146
Closed

Room transition animation happens twice since #2059 #2084

frebib opened this issue Dec 21, 2023 · 1 comment · Fixed by #2146
Assignees
Labels
A-Navigation O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@frebib
Copy link
Contributor

frebib commented Dec 21, 2023

Steps to reproduce

  1. Open a room from the room list
  2. Observe that the app now transitions once to the "unloaded room" and again to the "loaded room"

It's mostly visible on slower devices (my phone is new so is pretty quick, but enabling battery saver emulates it a little)

Outcome

What did you expect?

The previous behaviour. Reverting #2059 goes back to the old/expected behaviour.
Specifically, it seems that the issue is that there is a transition from the "unloaded timeline" to the "loaded timeline" whereas before it didn't do that.

What happened instead?

Here's a video I tried to capture of it happening. It's most visible in the last room opened

slow.mo.mp4

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

No

@frebib frebib added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Dec 21, 2023
@jmartinesp
Copy link
Member

I uploaded the video here in slow motion so it's a bit easier to see the issue. For whoever fixes this: take a look at the top app bar.

@jmartinesp jmartinesp added S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Navigation labels Dec 21, 2023
@ganfra ganfra self-assigned this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Navigation O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants