-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated crashing/bricked app #2105
Comments
Sadly, the logs won't tell us anything about where this crash originates, only that it's caused by some wrong constraints being passed to a text measuring operation, but that could be done either by us or automatically by the Compose UI components. At least we know it's happening on boot, so it's probably related to the room list screen or the pin/lockscreen, @idk-r-n do you have a pin or biometric unlock set up for the app? The log mentions a |
@jmartinesp there is no lock of any kind set. |
I can see the dialog to send a crash report, but the app crashes before I can even press "yes". |
I should note that the standard client with an account on a different server does not crash even though the same rooms were joined |
I've tried several things to try to trigger this behaviour, but sadly I could not reproduce it. Could you provide the id/alias of the room that was spammed, if it's public?
Thanks, we can discard this part of the app then.
Can you see the room list screen (or some placeholder of it) behind? A video could be useful too, if you can record one.
When you say 'the standard client' do you mean Element Android or Element X Android, but the stable version? |
It seems like it could be a Compose issue: https://issuetracker.google.com/issues/305978186 |
@jmartinesp The app says "offline" because I temporarily revoked network access in order to troubleshoot. Yes I meant im.vector.app |
Thanks! Do you remember which GrapheneOS room it was, in case it's a public room? Maybe I can find the offending message like this. In any case, given #2105 (comment) it seems like this is a Compose issue. We might be able to mitigate it by setting a max length for the string we use for the last message info in the room list, since the issue comes from trying to measure a text that's way too large (in either width or height) to fit in Compose |
Also, if you don't want to wait until this is fixed, deleting the app and reinstalling should solve the issue, if I'm not mistaken. This is probably caused by the last message displayed in the room list, and this is cached (which is why it's crashing for you every time you launch the app), but with a fresh start this should no longer be an issue. |
It was a public room, possibly the main one. I can try to find a permalink to messages around the same time.
I've tried clearing the cache multiple times, but it doesn't help. Do you know why this might be the case? |
Sorry, I just read your question. I think clearing the cache might be removing only image and file related cache, not the actual message list, which is stored in a DB by the Rust SDK. The only way to clear that is to clear the whole data of the app or reinstall if I'm not mistaken. I was able to reproduce the issue by creating a fake last message for one of the rooms consisting in thousands of characters without any new lines between them. So we'll work around the issue for now by setting a max length to the text to display until it's fixed in the Jetpack Compose library. |
@jmartinesp thanks for the fix it works great |
Steps to reproduce
After being a member of a room that was massively spammed, the app repeatedly crashed on launch. I am unable to to send a bug report from within the app.
Outcome
What did you expect?
The app to load.
What happened instead?
The app crashed.
Your phone model
Pixel 6
Operating system version
Android 14 - GrapheneOS - UQ1A.231205.015.2023121200
Application version and app store
version 0.4.0 io.element.android.x versionCode 40004000
Homeserver
matrix.org
Will you send logs?
Yes
Are you willing to provide a PR?
Yes
The text was updated successfully, but these errors were encountered: