Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fga/sync indicator api #1257

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 7, 2023

Closes #1244

@ganfra ganfra marked this pull request as ready for review September 7, 2023 19:59
@ganfra ganfra requested a review from a team as a code owner September 7, 2023 19:59
@ganfra ganfra requested review from bmarty and removed request for a team September 7, 2023 19:59
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 32.00% and project coverage change: -0.04% ⚠️

Comparison is base (b9f978b) 57.68% compared to head (61f5983) 57.65%.
Report is 7 commits behind head on develop.

❗ Current head 61f5983 differs from pull request most recent head 0e1d61b. Consider uploading reports for the commit 0e1d61b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1257      +/-   ##
===========================================
- Coverage    57.68%   57.65%   -0.04%     
===========================================
  Files         1081     1081              
  Lines        28024    28040      +16     
  Branches      5777     5777              
===========================================
- Hits         16167    16166       -1     
- Misses        9334     9350      +16     
- Partials      2523     2524       +1     
Files Changed Coverage Δ
...braries/matrix/impl/roomlist/RoomListExtensions.kt 0.00% <0.00%> (ø)
...raries/matrix/impl/roomlist/RustRoomListService.kt 0.00% <0.00%> (ø)
...ement/android/appnav/loggedin/LoggedInPresenter.kt 62.50% <75.00%> (-13.70%) ⬇️
...d/libraries/matrix/api/roomlist/RoomListService.kt 75.00% <100.00%> (+15.00%) ⬆️
...raries/matrix/test/roomlist/FakeRoomListService.kt 95.45% <100.00%> (+0.45%) ⬆️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and tested OK.

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/jjS7cu

@bmarty bmarty merged commit 5a0e0a8 into develop Sep 8, 2023
12 checks passed
@bmarty bmarty deleted the feature/fga/sync_indicator_api branch September 8, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new RoomListService::sync_indicator api
2 participants