Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push TimelineEvents further down the UI tree. #1424

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

julioromano
Copy link

So that timeline items don't have to route their callback all the way down to TimelinePresenter.

@julioromano julioromano requested a review from a team as a code owner September 25, 2023 15:15
@julioromano julioromano self-assigned this Sep 25, 2023
@julioromano julioromano requested review from bmarty and ganfra and removed request for a team September 25, 2023 15:15
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

So that timeline items don't have to route their callback all the way down to TimelinePresenter.
@julioromano julioromano force-pushed the julioromano/evenstinktotimelineview branch from 75181b1 to 82a9649 Compare September 25, 2023 15:20
@julioromano julioromano enabled auto-merge (squash) September 25, 2023 15:21
@julioromano julioromano enabled auto-merge (squash) September 25, 2023 15:21
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fo1gqj

@julioromano julioromano merged commit f4b46aa into develop Sep 25, 2023
12 checks passed
@julioromano julioromano deleted the julioromano/evenstinktotimelineview branch September 25, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants