Create UserStoryFlowPage

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Add a Page UserStoryFlowPage to our library to avoid duplicated code. Use it where appropriate.
Note: if reviewer can suggest a better name for this page, it will be welcome!

Motivation and context

Clean code, develop faster new UI with same wireframe.

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YSrCg8

[codecov]

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (74ccdf8) 63.33% compared to head (b2d0504) 63.34%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1737      +/-   ##
===========================================
+ Coverage    63.33%   63.34%   +0.01%     
===========================================
  Files         1286     1287       +1     
  Lines        33421    33360      -61     
  Branches      6962     6946      -16     
===========================================
- Hits         21167    21133      -34     
+ Misses        9057     9049       -8     
+ Partials      3197     3178      -19     

Files	Coverage Δ
...kscreen/impl/setup/biometric/SetupBiometricView.kt	40.00% <50.00%> (-11.22%)	⬇️
...securebackup/impl/enable/SecureBackupEnableView.kt	36.66% <70.00%> (+0.30%)	⬆️
...curebackup/impl/disable/SecureBackupDisableView.kt	59.15% <69.23%> (+3.86%)	⬆️
...element/android/features/logout/impl/LogoutView.kt	68.86% <75.86%> (+2.20%)	⬆️
...kup/impl/enter/SecureBackupEnterRecoveryKeyView.kt	45.23% <47.05%> (-0.80%)	⬇️
...ibraries/designsystem/atomic/pages/FlowStepPage.kt	38.70% <38.70%> (ø)
...s/securebackup/impl/setup/SecureBackupSetupView.kt	59.78% <57.40%> (+2.51%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

LGTM, thanks for the changes. I have a suggestion for the back button.

[jmartinesp]

Maybe making onBackClicked nullable would be enough? If it's present, we display the back button and set it up to use the lambda, otherwise we do nothing.

[bmarty]

Yes, good point, 7bd2ccd

[jmartinesp]

As for the name, would something like FlowStepPage work?

[bmarty]

As for the name, would something like FlowStepPage work?

Yes, it's better! Done in 163bc87

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information