Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bma/encrypted messages #1767

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 8, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : wording

Content

Wording change

Motivation and context

Closes #1754

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner November 8, 2023 09:44
@bmarty bmarty requested review from julioromano and removed request for a team November 8, 2023 09:44
Copy link
Contributor

github-actions bot commented Nov 8, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fbcq6K

@bmarty bmarty enabled auto-merge November 8, 2023 10:44
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26c28ff) 63.35% compared to head (64a00ee) 63.35%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1767   +/-   ##
========================================
  Coverage    63.35%   63.35%           
========================================
  Files         1287     1287           
  Lines        33366    33366           
  Branches      6948     6948           
========================================
  Hits         21139    21139           
  Misses        9049     9049           
  Partials      3178     3178           
Files Coverage Δ
...line/components/event/TimelineItemEncryptedView.kt 45.45% <100.00%> (ø)
...tformatter/impl/DefaultRoomLastMessageFormatter.kt 95.52% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit d99ed85 into develop Nov 8, 2023
15 checks passed
@bmarty bmarty deleted the feature/bma/encryptedMessages branch November 8, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyBackup: use common_waiting_for_decryption_key for message which cannot be decrypted
2 participants