Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full history if key backup is enabled. #1770

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 8, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

If KeyBackup is enabled, do not show the no history banner in encrypted room.

Motivation and context

Closes #1768

Screenshots / GIFs

Tests

  • Log in to an account with a e2e room RoomA with messages.
  • Verify the session
  • Open RoomA and see that the banner is displayed
  • From the setting, enter the recovery key to unlock the chat backup
  • open the RoomA
  • observe that the history of the room is visible (and decrypted if the keys are in the backup)

Before this PR, the banner was always displayed, event if the history was present and decrypted.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner November 8, 2023 11:45
@bmarty bmarty requested review from ganfra and removed request for a team November 8, 2023 11:45
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

github-actions bot commented Nov 8, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ePUnMx

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not dynamic if the KeyBackUp is enabled/disabled while in a room, but I guess it's no big deal :-)

@bmarty
Copy link
Member Author

bmarty commented Nov 8, 2023

This is not dynamic if the KeyBackUp is enabled/disabled while in a room, but I guess it's no big deal :-)

No, but I do not think it's possible, since the user will need to go back to the room list to go to the settings.

@bmarty bmarty merged commit 8e7075b into develop Nov 8, 2023
13 of 14 checks passed
@bmarty bmarty deleted the feature/bma/noBannerIfKeyBackIsEnabled branch November 8, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyBackup: do not show the "Message history" banner if key backup is set up.
2 participants