Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeline item for m.call.notify events #2986

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add timeline item for m.call.notify events.

Motivation and context

Part of #2894 .

Screenshots / GIFs

image

Tests

  • Go into a room where a call happened, or start a new one.
  • Check there is a timeline item for the event now.
  • If there is an ongoing call, the timeline item will have a Join button instead of the time of the event, which will open the call screen.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

Copy link
Contributor

github-actions bot commented Jun 6, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hbi8qc

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 36 lines in your changes missing coverage. Please review.

Project coverage is 75.77%. Comparing base (30a1367) to head (1acaed0).

Files Patch % Lines
...ssages/impl/timeline/components/TimelineItemRow.kt 67.56% 6 Missing and 6 partials ⚠️
...ent/android/features/messages/impl/MessagesView.kt 72.72% 1 Missing and 2 partials ⚠️
.../timeline/components/TimelineItemCallNotifyView.kt 92.50% 0 Missing and 3 partials ⚠️
...es/messages/impl/actionlist/ActionListPresenter.kt 50.00% 1 Missing and 1 partial ⚠️
...eatures/messages/impl/actionlist/ActionListView.kt 0.00% 1 Missing and 1 partial ⚠️
...sages/impl/timeline/components/JoinCallMenuItem.kt 75.00% 0 Missing and 2 partials ⚠️
...tformatter/impl/DefaultRoomLastMessageFormatter.kt 0.00% 2 Missing ⚠️
...entformatter/impl/DefaultTimelineEventFormatter.kt 0.00% 2 Missing ⚠️
...ndroid/features/messages/impl/MessagesPresenter.kt 0.00% 0 Missing and 1 partial ⚠️
...imeline/components/TimelineItemGroupedEventsRow.kt 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2986      +/-   ##
===========================================
- Coverage    75.79%   75.77%   -0.02%     
===========================================
  Files         1605     1608       +3     
  Lines        37983    38066      +83     
  Branches      7332     7357      +25     
===========================================
+ Hits         28789    28846      +57     
- Misses        5354     5374      +20     
- Partials      3840     3846       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feature/jme/element-call-ringing-with-telecom to develop June 10, 2024 09:51
@jmartinesp jmartinesp force-pushed the feature/jme/add-incoming-call-timeline-items branch from 7eef895 to 1acaed0 Compare June 10, 2024 10:05
@jmartinesp jmartinesp marked this pull request as ready for review June 10, 2024 10:14
@jmartinesp jmartinesp requested a review from a team as a code owner June 10, 2024 10:14
@jmartinesp jmartinesp requested review from ganfra and removed request for a team June 10, 2024 10:14
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one remark not directly related to this PR

@@ -324,6 +322,7 @@ private fun MessagesViewContent(
onTimestampClick: (TimelineItem.Event) -> Unit,
onSendLocationClick: () -> Unit,
onCreatePollClick: () -> Unit,
onJoinCallClick: () -> Unit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start refactoring this to avoid having a very long list of lambdas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm thinking the same. I'll try to come up with something to group the different lambdas in a separate PR.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 10, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 10, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) June 10, 2024 14:44
@jmartinesp jmartinesp merged commit 02d6fa7 into develop Jun 10, 2024
23 of 25 checks passed
@jmartinesp jmartinesp deleted the feature/jme/add-incoming-call-timeline-items branch June 10, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants