-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeline item for m.call.notify
events
#2986
Add timeline item for m.call.notify
events
#2986
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
7eef895
to
1acaed0
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one remark not directly related to this PR
@@ -324,6 +322,7 @@ private fun MessagesViewContent( | |||
onTimestampClick: (TimelineItem.Event) -> Unit, | |||
onSendLocationClick: () -> Unit, | |||
onCreatePollClick: () -> Unit, | |||
onJoinCallClick: () -> Unit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start refactoring this to avoid having a very long list of lambdas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm thinking the same. I'll try to come up with something to group the different lambdas in a separate PR.
Type of change
Content
Add timeline item for
m.call.notify
events.Motivation and context
Part of #2894 .
Screenshots / GIFs
Tests
Tested devices
Checklist