Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify of ringing call when there's an active call #3003

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Makes sure the user is notified of a new call even when there is an active call though an 'incoming call' not ringing notification.

Motivation and context

I forgot this use case.

Tests

This can be difficult to test since you'll need 3 accounts.

  • From account A call account B from a DM (it'll send a ringing notification).
  • Quickly, from account C call account B too from a DM.
  • An 'incoming call' notification should be displayed.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14, 13.

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner June 10, 2024 12:45
@jmartinesp jmartinesp requested review from bmarty and removed request for a team June 10, 2024 12:45
Copy link
Contributor

github-actions bot commented Jun 10, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Vxi5Pv

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 91.54930% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (30a1367) to head (8907672).

Files Patch % Lines
...ications/DefaultOnMissedCallNotificationHandler.kt 60.00% 0 Missing and 4 partials ⚠️
...mpl/notifications/CallNotificationEventResolver.kt 94.44% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3003   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files         1605     1608    +3     
  Lines        37983    38015   +32     
  Branches      7332     7337    +5     
========================================
+ Hits         28789    28814   +25     
  Misses        5354     5354           
- Partials      3840     3847    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ng notification to be non-ringing given an existing ringing one.
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 10, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 10, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) June 10, 2024 14:54
@jmartinesp jmartinesp merged commit f07ec61 into develop Jun 10, 2024
25 checks passed
@jmartinesp jmartinesp deleted the fix/jme/add-missed-call-when-already-ringing-call branch June 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants