-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to workaround OOM errors and the runners dying #3013
Try to workaround OOM errors and the runners dying #3013
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3013 +/- ##
===========================================
- Coverage 75.78% 75.78% -0.01%
===========================================
Files 1611 1611
Lines 38098 38098
Branches 7362 7362
===========================================
- Hits 28872 28871 -1
Misses 5374 5374
- Partials 3852 3853 +1 ☔ View full report in Codecov by Sentry. |
- Add `-XX:MaxMetaspaceSize` (gradle/gradle#19750) - Remove `-PpreDexEnable` as it's deprecated and no longer used. - Remove `--max-workers` as gradle will automatically use the optimal amount.
Quality Gate passedIssues Measures |
@jmartinesp record screenshots failed somehow |
It failed because it had nothing to commit, but the gradle runs worked fine which is what I wanted to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok lets merge!
Type of change
Content
checkDependencies
.With these changes all CI jobs should pass again (for now).
Motivation and context
Once again we have issues where either we get OOM errors if the max heap size is too low or we bump it to 7GB and the runner dies (even though technically it should have 14GB for us, so maybe the kotlin compiler takes the rest).
I still don't really understand what's happening to be honest, because locally the RAM memory usage I get when running the same CI jobs are way lower (as in, almost half). This might be related to some bug on AGP, or some other plugin, no idea...
Tests
All CI jobs should be green.
Checklist