-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element enterprise (EE) foundations #3025
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3025 +/- ##
===========================================
+ Coverage 75.97% 75.99% +0.01%
===========================================
Files 1634 1635 +1
Lines 38611 38618 +7
Branches 7463 7463
===========================================
+ Hits 29335 29346 +11
Misses 5384 5384
+ Partials 3892 3888 -4 ☔ View full report in Codecov by Sentry. |
f469517
to
fe62d10
Compare
…t has been copied in `NotificationChannels.kt`
…n Enterprise builds
950fb9e
to
6e14046
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
This allow to let the correct Copyright be applied when creating new file.
This is not strictly necessary, since if the enterprise modules are not there, nothing will be included by `allEnterpriseImpl()`, but for clarity, it's better to add this check.
Quality Gate passedIssues Measures |
@@ -0,0 +1,6 @@ | |||
<component name="CopyrightManager"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name file Element_Enterprise
so it's aligned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good idea, but not a big deal. I'll rename it later.
Type of change
Content
Foundations for Element Enterprise.
The changes include:
EnterpriseService
,api
and defaultimpl
module, including unit tests.Motivation and context
Be able to create Element Enterprise application
Screenshots / GIFs
NA
Tests
Tested devices
Checklist