Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element enterprise (EE) foundations #3025

Merged
merged 29 commits into from
Jul 1, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 12, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : build Element Enterprise

Content

Foundations for Element Enterprise.
The changes include:

  • new CI job to build Element Enterprise
  • new CI job to build Element Enterprise nightly (not tested yet)
  • CI step to build Element Enterprise App Bundle release
  • add quality check on Element Enterprise modules
  • idea configuration to apply correct copyright header on EE source files and quality check to ensure header are correct
  • build variant for EE: appId, application name
  • a first EnterpriseService, api and default impl module, including unit tests.
  • a log of which type of build is done to ensure developer do not get confused
  • EE will be build with API 26, but we will increase this value in the future.

Motivation and context

Be able to create Element Enterprise application

Screenshots / GIFs

NA

Tests

  • There should be no visible change in the application Element X Android itself.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (81a5394) to head (7d3c447).
Report is 65 commits behind head on develop.

Files Patch % Lines
...c/main/kotlin/io/element/android/x/di/AppModule.kt 0.00% 2 Missing ⚠️
...ures/rageshake/impl/reporter/DefaultBugReporter.kt 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3025      +/-   ##
===========================================
+ Coverage    75.97%   75.99%   +0.01%     
===========================================
  Files         1634     1635       +1     
  Lines        38611    38618       +7     
  Branches      7463     7463              
===========================================
+ Hits         29335    29346      +11     
  Misses        5384     5384              
+ Partials      3892     3888       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty force-pushed the feature/bma/elementEnterprise branch from f469517 to fe62d10 Compare June 14, 2024 09:43
@bmarty bmarty force-pushed the feature/bma/elementEnterprise branch from 950fb9e to 6e14046 Compare June 26, 2024 12:50
Copy link
Contributor

github-actions bot commented Jun 27, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/KjXDms

@bmarty bmarty changed the title Element enterprise - WIP Element enterprise (EE) foundations Jul 1, 2024
@bmarty bmarty marked this pull request as ready for review July 1, 2024 09:38
@bmarty bmarty requested a review from a team as a code owner July 1, 2024 09:38
@bmarty bmarty requested review from ganfra and removed request for a team July 1, 2024 09:38
bmarty and others added 3 commits July 1, 2024 11:53
This is not strictly necessary, since if the enterprise modules are not there, nothing will be included by `allEnterpriseImpl()`, but for clarity, it's better to add this check.
@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Jul 1, 2024
Copy link

sonarcloud bot commented Jul 1, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 1, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 1, 2024
@@ -0,0 +1,6 @@
<component name="CopyrightManager">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name file Element_Enterprise so it's aligned?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good idea, but not a big deal. I'll rename it later.

@bmarty bmarty merged commit 6c4e7ec into develop Jul 1, 2024
32 of 33 checks passed
@bmarty bmarty deleted the feature/bma/elementEnterprise branch July 1, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants