Feature/bma/fix fdroid notification

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Fix issue on code running twice, and add more log regarding pusher registration.

This change also include a dialog to help user with no distributor installed. For UnifiedPush, this will act like this:

Also: if several push distributors are available (Firebase + UnifiedPush), the application will use Firebase by default (as before), but if not available, it will fallback to UnifiedPush is a UnifiedPush distributor is available on the system.

Motivation and context

Help investigate #3031

Screenshots / GIFs

Tests

• Install Ntfy
• Use F-Droid variant
• Connect to a Matrix account
• Check that the notification troubleshoot does not report any error
• The application is receiving push and notification are displayed.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[bmarty]

Checking isVerified first, else ensurePusherIsRegistered() is called twice:

By checking first the value:

[bmarty]

Fixed by bc30aee

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CHMSFh

[codecov]

Codecov Report

Attention: Patch coverage is 73.37278% with 45 lines in your changes missing coverage. Please review.

Project coverage is 75.87%. Comparing base (849f64f) to head (d69a5ee).
Report is 7 commits behind head on develop.

Files	Patch %	Lines
...io/element/android/appnav/loggedin/LoggedInView.kt	34.61%	8 Missing and 9 partials ⚠️
...omponents/dialogs/ErrorDialogWithDoNotShowAgain.kt	75.00%	0 Missing and 7 partials ⚠️
...ement/android/appnav/loggedin/LoggedInPresenter.kt	92.15%	2 Missing and 2 partials ⚠️
...droid/appnav/loggedin/PusherRegistrationFailure.kt	57.14%	3 Missing ⚠️
...droid/libraries/architecture/appyx/BackStackExt.kt	0.00%	3 Missing ⚠️
.../android/libraries/push/impl/DefaultPushService.kt	50.00%	3 Missing ⚠️
...id/libraries/pushproviders/api/PusherSubscriber.kt	0.00%	3 Missing ⚠️
...oid/libraries/push/impl/DefaultPusherSubscriber.kt	66.66%	1 Missing and 1 partial ⚠️
.../features/preferences/api/PreferencesEntryPoint.kt	0.00%	1 Missing ⚠️
...s/preferences/impl/DefaultPreferencesEntryPoint.kt	0.00%	0 Missing and 1 partial ⚠️
... and 1 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3035      +/-   ##
===========================================
+ Coverage    75.81%   75.87%   +0.06%     
===========================================
  Files         1623     1628       +5     
  Lines        38208    38349     +141     
  Branches      7363     7401      +38     
===========================================
+ Hits         28966    29097     +131     
+ Misses        5391     5382       -9     
- Partials      3851     3870      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ganfra]

LGTM!
Lets just change the isVerified to keep the state inside the LaunchedEffect

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud