Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full date format for day dividers in timeline #3057

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : improve UX

Content

  • Adds a new dateWithFullFormatFormatter that will use the same format as iOS.
  • Changes the onlyTimeFormatter so it also adds AM/PM for locales that use them.

Motivation and context

Fixes #2916.

Screenshots / GIFs

Before After
image image
image image

Tests

  • Check the new formats are used.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner June 20, 2024 12:12
@jmartinesp jmartinesp requested review from ganfra and removed request for a team June 20, 2024 12:12
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/58Rqmc

Copy link

sonarcloud bot commented Jun 20, 2024

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.91%. Comparing base (4317b80) to head (8bb504e).

Files Patch % Lines
...dateformatter/impl/DefaultDaySeparatorFormatter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3057   +/-   ##
========================================
  Coverage    75.91%   75.91%           
========================================
  Files         1628     1628           
  Lines        38409    38411    +2     
  Branches      7421     7420    -1     
========================================
+ Hits         29158    29160    +2     
  Misses        5375     5375           
  Partials      3876     3876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 20, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) June 20, 2024 12:42
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 20, 2024
@jmartinesp jmartinesp merged commit 4f69ab7 into develop Jun 20, 2024
28 checks passed
@jmartinesp jmartinesp deleted the misc/jme/2916-improve-day-dividers-format branch June 20, 2024 13:09
@ganfra ganfra added the PR-Misc For other changes label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a sane date format for day markers
2 participants