Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar cluster for DM #3069

Merged
merged 9 commits into from
Jun 24, 2024
Merged

Avatar cluster for DM #3069

merged 9 commits into from
Jun 24, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 21, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Let DM detail to render both user and other user Avatar. Also render "Encrypted" badges in DM.

Before After
image image

Also fix some rendering avatar issue.

Figma: https://www.figma.com/design/A2pAEvTEpJZBiOPUlcMnKi/Settings-%2B-Room-Details-(new)?node-id=1787-54050&m=dev

Motivation and context

Parity with EXI

Screenshots / GIFs

See recorded screenshot

Tests

  • Open a DM
  • Navigate to the room settings
  • Observe that 2 avatars are rendered

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner June 21, 2024 13:57
@bmarty bmarty requested review from ganfra and removed request for a team June 21, 2024 13:57
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 21, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jun 21, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/TTfDHT

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 21, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 21, 2024
data class Dm(val roomMember: RoomMember) : RoomDetailsType
data class Dm(
val me: RoomMember,
val roomMember: RoomMember,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

named otherMember maybe?

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 82.52427% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.92%. Comparing base (981dad7) to head (f0917ad).
Report is 4 commits behind head on develop.

Current head f0917ad differs from pull request most recent head 5ccaeea

Please upload reports for the commit 5ccaeea to get more accurate results.

Files Patch % Lines
...droid/features/roomdetails/impl/RoomDetailsView.kt 86.95% 2 Missing and 4 partials ⚠️
...raries/designsystem/components/avatar/DmAvatars.kt 81.81% 1 Missing and 5 partials ⚠️
...roid/libraries/matrix/ui/room/MatrixRoomMembers.kt 33.33% 1 Missing and 3 partials ⚠️
.../features/roomdetails/impl/RoomDetailsPresenter.kt 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3069      +/-   ##
===========================================
- Coverage    75.93%   75.92%   -0.01%     
===========================================
  Files         1631     1632       +1     
  Lines        38506    38566      +60     
  Branches      7436     7451      +15     
===========================================
+ Hits         29238    29282      +44     
- Misses        5387     5391       +4     
- Partials      3881     3893      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 010a90f into develop Jun 24, 2024
18 checks passed
@bmarty bmarty deleted the feature/bma/avatarCluster_x2 branch June 24, 2024 08:53
Copy link

sonarcloud bot commented Jun 24, 2024

@ganfra ganfra added the PR-Feature For a new feature label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants