-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar cluster for DM #3069
Avatar cluster for DM #3069
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
data class Dm(val roomMember: RoomMember) : RoomDetailsType | ||
data class Dm( | ||
val me: RoomMember, | ||
val roomMember: RoomMember, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
named otherMember
maybe?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3069 +/- ##
===========================================
- Coverage 75.93% 75.92% -0.01%
===========================================
Files 1631 1632 +1
Lines 38506 38566 +60
Branches 7436 7451 +15
===========================================
+ Hits 29238 29282 +44
- Misses 5387 5391 +4
- Partials 3881 3893 +12 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Type of change
Content
Let DM detail to render both user and other user Avatar. Also render "Encrypted" badges in DM.
Also fix some rendering avatar issue.
Figma: https://www.figma.com/design/A2pAEvTEpJZBiOPUlcMnKi/Settings-%2B-Room-Details-(new)?node-id=1787-54050&m=dev
Motivation and context
Parity with EXI
Screenshots / GIFs
See recorded screenshot
Tests
Tested devices
Checklist