-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the way we cut the bubble layout to give space for the sender Avatar #3080
Conversation
… Avatar. Instead of drawing a circle with the same color of the background behind the avatar, properly clear the top start corner of the bubble using `CompositingStrategy.Offscreen` and `BlendMode.Clear`.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3080 +/- ##
========================================
Coverage 75.93% 75.94%
========================================
Files 1633 1633
Lines 38584 38589 +5
Branches 7457 7460 +3
========================================
+ Hits 29300 29305 +5
Misses 5394 5394
Partials 3890 3890 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Quality Gate passedIssues Measures |
Type of change
Content
Improve the way we cut the bubble layout to give space for the sender Avatar.
Instead of drawing a circle with the same color of the background behind the avatar, properly clear the top start corner of the bubble using
CompositingStrategy.Offscreen
andBlendMode.Clear
.Note about the screenshot record: the only diff should be in MessageEventBubble, where some bubbles now have top left corner cut off. I do not know why so many screenshots are impacted, but I have done a quick check and I do not see any visible change.
Note 2: this change will help to fix a point in #2865
Motivation and context
Screenshots / GIFs
See recorded ones
Tests
Tested devices
Checklist