Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way we cut the bubble layout to give space for the sender Avatar #3080

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 24, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : fixing technical debt

Content

Improve the way we cut the bubble layout to give space for the sender Avatar.

Instead of drawing a circle with the same color of the background behind the avatar, properly clear the top start corner of the bubble using CompositingStrategy.Offscreen and BlendMode.Clear.

Note about the screenshot record: the only diff should be in MessageEventBubble, where some bubbles now have top left corner cut off. I do not know why so many screenshots are impacted, but I have done a quick check and I do not see any visible change.

Note 2: this change will help to fix a point in #2865

Motivation and context

Screenshots / GIFs

See recorded ones

Tests

  • Open a DM or open a room and see that the bubbles in the timeline are correctly rendered

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

bmarty and others added 2 commits June 24, 2024 11:21
… Avatar.

Instead of drawing a circle with the same color of the background behind the avatar, properly clear the top start corner of the bubble using `CompositingStrategy.Offscreen` and `BlendMode.Clear`.
@bmarty bmarty requested a review from a team as a code owner June 24, 2024 09:47
@bmarty bmarty requested review from ganfra and jmartinesp and removed request for a team and ganfra June 24, 2024 09:47
Copy link
Contributor

github-actions bot commented Jun 24, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Eukkko

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (010a90f) to head (d14b9de).

Files Patch % Lines
...ges/impl/timeline/components/MessageEventBubble.kt 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3080   +/-   ##
========================================
  Coverage    75.93%   75.94%           
========================================
  Files         1633     1633           
  Lines        38584    38589    +5     
  Branches      7457     7460    +3     
========================================
+ Hits         29300    29305    +5     
  Misses        5394     5394           
  Partials      3890     3890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the changes!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 24, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 24, 2024
@bmarty bmarty enabled auto-merge June 24, 2024 10:09
Copy link

sonarcloud bot commented Jun 24, 2024

@bmarty bmarty merged commit cb14be2 into develop Jun 24, 2024
27 checks passed
@bmarty bmarty deleted the feature/bma/improveBubbleLayout branch June 24, 2024 10:27
@ganfra ganfra added the PR-Misc For other changes label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants