-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image rendering after clear cache #3082
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3082 +/- ##
===========================================
+ Coverage 75.94% 75.98% +0.04%
===========================================
Files 1633 1634 +1
Lines 38589 38595 +6
Branches 7460 7460
===========================================
+ Hits 29305 29326 +21
+ Misses 5394 5379 -15
Partials 3890 3890 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Type of change
Content
Ensure that after a clear cache from the application settings, the Matrix images (room and user avatar, images in timeline, etc.) are correctly rendered.
Also doing some cleanup, rework and add a unit test (see per commit)
Motivation and context
Fix existing bug.
Screenshots / GIFs
Tests
Previous: the room avatars are not rendered, the initial avatars are diaplyed
Now: the room avatars are loaded correctly
Tested devices
Checklist