Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image rendering after clear cache #3082

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 24, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure that after a clear cache from the application settings, the Matrix images (room and user avatar, images in timeline, etc.) are correctly rendered.

Also doing some cleanup, rework and add a unit test (see per commit)

Motivation and context

Fix existing bug.

Screenshots / GIFs

Tests

  • Start the app and navigate to the room list. There are some room avatars in the list.
  • From the developer setting, clear the cache

Previous: the room avatars are not rendered, the initial avatars are diaplyed
Now: the room avatars are loaded correctly

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner June 24, 2024 12:45
@bmarty bmarty requested review from ganfra and removed request for a team June 24, 2024 12:45
@bmarty bmarty requested review from jmartinesp and removed request for ganfra June 24, 2024 12:47
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/dmJGC3

Copy link

sonarcloud bot commented Jun 24, 2024

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.98%. Comparing base (cb14be2) to head (40594b7).

Files Patch % Lines
...ent/android/appnav/root/RootNavStateFlowFactory.kt 0.00% 2 Missing ⚠️
.../libraries/matrix/ui/media/ImageLoaderFactories.kt 0.00% 2 Missing ⚠️
...essionstorage/test/observer/FakeSessionObserver.kt 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3082      +/-   ##
===========================================
+ Coverage    75.94%   75.98%   +0.04%     
===========================================
  Files         1633     1634       +1     
  Lines        38589    38595       +6     
  Branches      7460     7460              
===========================================
+ Hits         29305    29326      +21     
+ Misses        5394     5379      -15     
  Partials      3890     3890              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 24, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 24, 2024
@bmarty bmarty enabled auto-merge June 24, 2024 13:55
@bmarty bmarty merged commit 72373ab into develop Jun 24, 2024
26 of 27 checks passed
@bmarty bmarty deleted the feature/bma/fixClearCacheImage branch June 24, 2024 14:20
@ganfra ganfra added the PR-Bugfix For bug fix label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants